Repository navigation
Moves case studies from Private Key section to a dedicated section - #161
Conversation
Also splits the four case studies into dedicated pages.
Added case studies to the guide overview page. Revised case studies intro paragraph (was still copy/pasted from the private key section).
|
Looks a bit weird without the nesting imo. The terminology isn't really self-explanatory and as |
|
@pavlenex there is nesting. Is is too subtle to see? Agree about the naming, that needs to be clarified without becoming super long. We have to keep in mind though that this is navigation, and that people can go to the "Case study" landing page for longer descriptions. So this short nav item doesn't have to cover everything (should be more precise than it currently is though). |
|
@GBKS I mean, as we add stuff, it probably should to be categorized.
|
|
@pavlenex got it, let's tackle that separately. I'll add two-level nesting as a new issue as we don't have that functionality yet. I'm also wondering if we won't have overlap between case studies - there might be one that deals with both onboarding, private keys and accessibility, for example. Not sure how we'd organize that. |
|
Looks good to me. Minor comments:
|
danielnordh
left a comment
There was a problem hiding this comment.
Looking good, approved.
|
|
||
| {% include prototype.html | ||
| link = "https://www.figma.com/proto/SRWlaxbDulsacpPQn2TTri/Case-study-prototypes?node-id=1%3A3&viewport=1357%2C576%2C1&scaling=scale-down" | ||
| image = "/assets/images/guide/case-studies/case-cash.png" |
There was a problem hiding this comment.
Might be for another PR and I think it's been mentioned before, but should we start using SVG's instead so we can simplify and use one image now?
There was a problem hiding this comment.
Good call. We should do a review of this across the whole guide before we go live with V1.

Also splits the four case studies into dedicated pages.
No changes were made to the case study content. Only addition was a landing page that lists the case studies and has a short description for each one.
I find this helpful to get a feel for what we already have in terms of case studies, what seems missing, etc.